-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Allow initializing manually and shutting down SentrySDK #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5b03693 to
0b5f933
Compare
|
@sentry review |
This reverts commit d548380.
android_lib/src/main/java/io/sentry/godotplugin/SentryAndroidGodotPlugin.kt
Show resolved
Hide resolved
jpnurmi
approved these changes
Sep 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the tests are somehow easier to understand at a glance because the SentrySDK.init() call is visible. LGTM 👍
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new lifecycle methods to the
SentrySDKclass:init(),close(), andis_enabled(). These methods are similar to what you’ll find in other SDKs. By default, the SDK tries to initialize itself automatically if "Auto Init" is enabled in the project settings. If disabled, devs can still manually initialize the SDK by callinginit().close()allows shutting down the previously initialized SDK.This makes configuration script approach obsolete, giving us two clear options:
Additionally,
options.enabledis renamed toauto_initfor better clarity, as suggested by @bruno-garcia here.Check #257 (comment) for more details.
Breaking changes
enabledoption is renamed toauto_initfor clarity, and removed from SentryOptions properties (setting it from code has no sense - we auto-initialize very early).disabled_in_editor_playoption is renamed toskip_auto_init_on_editor_playfor clarity, and removed from SentryOptions properties.How to initialize and configure the SDK from code
The earliest you can initialize the SDK is in the
MainLoop._initialize(). Here's how you can do it:_initialize()method.application/run/main_loop_type("MyMainLoop" in the example code).