More ClientOptions.Release documentation #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Briefly explain importance of setting a release - Document that release may be derived from env or git - Recommend setting the release during build - Apply build-time release pattern to examples
rhcarvalho
commented
Jun 22, 2021
Comment on lines
+25
to
+30
| // release is the release of this program that will be reported to Sentry. | ||
| // Use go build -ldflags='-X main.release=VALUE' to set this value in build | ||
| // time. | ||
| // If not set, a default release value will be derived in runtime from | ||
| // environment variables or the Git repository in the current working directory. | ||
| var release string |
There was a problem hiding this comment.
If we're happy with this suggestion, I'd add the same to other examples, and a similar bit of explanation to https://docs.sentry.io.
AbhiPrasad
approved these changes
Jun 22, 2021
kamilogorek
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #363.