feat: Automatic Release detection (#335) #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AramisHM
force-pushed
the
automatic-release-detection
branch
2 times, most recently
from
a972959 to
5d9e534
Compare
messer
reviewed
Jun 3, 2021
rhcarvalho
suggested changes
Jun 8, 2021
There was a problem hiding this comment.
@AramisHM thanks for your contribution, muito obrigado! Only required change is to not introduce any new exported symbol. We can always revisit how exactly the automatic detection works later.
Attempts to guess the release info, either by getting the last git commit hash or by looking up some known environment variables that tracks release identification.
AramisHM
force-pushed
the
automatic-release-detection
branch
from
5d9e534 to
790558d
Compare
|
Thank you for taking the time to deal with a newbie. Wasn't sure if create a new commit, ended up force pushing the new code on top of the old one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to guess the release info, either by getting the last git
commit hash or by looking up some know environment variables that tracks
release identification.
Had to make changes on some tests, though I am not sure if what I wrote there is appropriated.
Closes #335.