Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http.RoundTripper in place of *http.Transport #205

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Use http.RoundTripper in place of *http.Transport #205

merged 1 commit into from
Apr 16, 2020

Conversation

flimzy
Copy link
Contributor

@flimzy flimzy commented Apr 16, 2020

Fixes #204

rhcarvalho
rhcarvalho approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely how it should've been.

Muito obrigado @flimzy 😉

@rhcarvalho rhcarvalho merged commit 7bf3e16 into getsentry:master Apr 16, 2020
@flimzy flimzy deleted the roundTripper branch April 16, 2020 09:24
@flimzy
Copy link
Contributor Author

flimzy commented Apr 16, 2020

Wow, thanks for the speedy merge! Now my unit tests can be greatly simplified! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClientOptions.Transport should be of type http.RoundTripper
2 participants
@flimzy @rhcarvalho