Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientOptions.Transport should be of type http.RoundTripper #204

Closed
flimzy opened this issue Apr 16, 2020 · 0 comments · Fixed by #205
Closed

ClientOptions.Transport should be of type http.RoundTripper #204

flimzy opened this issue Apr 16, 2020 · 0 comments · Fixed by #205

Comments

@flimzy
Copy link
Contributor

flimzy commented Apr 16, 2020

At present, ClientOptions contains the following field:

    // An optional pointer to `http.Transport` that will be used with a default HTTPTransport.
    // Using your own transport will make HTTPProxy, HTTPSProxy and CaCerts options ignored.
    HTTPTransport *http.Transport

*http.Transport is meant to be used as an implementation of the http.RoundTripper interface.

Updating all instances of *http.Transport to http.RoundTripper seems to work perfectly, so this should not even be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant