feat: Add network details for session replay on iOS#4891
feat: Add network details for session replay on iOS#4891jamescrosswell merged 29 commits intomainfrom
Conversation
… .NET and Java replay breadcrumbs
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add network details for session replay on iOS ([#4891](https://github.com/getsentry/sentry-dotnet/pull/4891))If none of the above apply, you can opt out of this check by adding |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4891 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 499 499
Lines 18065 18066 +1
Branches 3518 3518
=======================================
+ Hits 13370 13372 +2
+ Misses 3836 3835 -1
Partials 859 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Features ✨
Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed:
ToCocoaBreadcrumbDatais never called in production codeBreadcrumbExtensions.ToCocoaBreadcrumbnow usesToCocoaBreadcrumbData, sorequest_startis converted toNSDatefor Cocoa Session Replay network breadcrumb parsing.
Or push these changes by commenting:
@cursor push d93cff9153
Preview (d93cff9153)
diff --git a/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs b/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
--- a/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
+++ b/src/Sentry/Platforms/Cocoa/Extensions/BreadcrumbExtensions.cs
@@ -19,7 +19,7 @@
Timestamp = breadcrumb.Timestamp.ToNSDate(),
Message = breadcrumb.Message,
Type = breadcrumb.Type,
- Data = breadcrumb.Data?.ToNullableNSDictionary(),
+ Data = breadcrumb.Data?.ToCocoaBreadcrumbData(),
Category = breadcrumb.Category ?? "",
Level = breadcrumb.Level.ToCocoaSentryLevel()
};This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Sentry.Maui](https://sentry.io/) ([source](https://github.com/getsentry/sentry-dotnet)) | nuget | minor | `6.3.2` -> `6.4.0` | --- ### Release Notes <details> <summary>getsentry/sentry-dotnet (Sentry.Maui)</summary> ### [`v6.4.0`](https://github.com/getsentry/sentry-dotnet/blob/HEAD/CHANGELOG.md#640) [Compare Source](getsentry/sentry-dotnet@6.3.2...6.4.0) ##### Features ✨ - feat: Add network details for session replay on iOS by [@​jamescrosswell](https://github.com/jamescrosswell) in [#​4891](getsentry/sentry-dotnet#4891) - feat: Add option to exclude certain HTTP statuses from tracing by [@​jamescrosswell](https://github.com/jamescrosswell) in [#​5034](getsentry/sentry-dotnet#5034) ##### Fixes 🐛 - fix: memory leak when profiling is enabled by [@​jamescrosswell](https://github.com/jamescrosswell) in [#​5133](getsentry/sentry-dotnet#5133) - fix: prevent redundant native exceptions on iOS by [@​jpnurmi](https://github.com/jpnurmi) in [#​5126](getsentry/sentry-dotnet#5126) - fix: prevent redundant native exceptions on Android/Mono by [@​jpnurmi](https://github.com/jpnurmi) in [#​4676](getsentry/sentry-dotnet#4676) - Note: opt in by setting `options.Native.ExperimentalOptions.SignalHandlerStrategy` to `Sentry.Android.SignalHandlerStrategy.ChainAtStart` ##### Dependencies ⬆️ ##### Deps - chore(deps): update Cocoa SDK to v9.10.0 by [@​github-actions](https://github.com/github-actions) in [#​5132](getsentry/sentry-dotnet#5132) - chore(deps): update Cocoa SDK to v9.9.0 by [@​github-actions](https://github.com/github-actions) in [#​5115](getsentry/sentry-dotnet#5115) - chore(deps): update Java SDK to v8.38.0 by [@​github-actions](https://github.com/github-actions) in [#​5124](getsentry/sentry-dotnet#5124) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).


Resolves #4890:
Remarks
There are a couple of things about this PR that make me nervous:
EnableSessionReplayInUnreliableEnvironmentI'd recommend we leave this experimental for quite some time to try to get a feel for whether either of these things is going to be a deal breaker.
Example