Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Aug 19, 2025

#skip-changelog

  • Workaround for runner issues with iOS 18.0 missing.
  • Update macos-latest to macos-15 explicitly, to have correct runtimes available.
  • Fix analyzer issues

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (3a1ba4d) to head (8ce7ab8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
+ Coverage   87.78%   88.02%   +0.24%     
==========================================
  Files         291      105     -186     
  Lines        9896     3657    -6239     
==========================================
- Hits         8687     3219    -5468     
+ Misses       1209      438     -771     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.77 ms 1267.90 ms 22.13 ms
Size 20.70 MiB 22.46 MiB 1.75 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2cb90b9 1272.90 ms 1285.55 ms 12.66 ms
dbd526b 1244.78 ms 1259.02 ms 14.24 ms
81f83eb 1259.53 ms 1273.39 ms 13.86 ms
793f4dc 1262.50 ms 1282.35 ms 19.85 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
4481076 1256.48 ms 1266.64 ms 10.17 ms
cc4e375 1253.06 ms 1263.81 ms 10.75 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
ec78888 1251.37 ms 1269.40 ms 18.04 ms

App size

Revision Plain With Sentry Diff
2cb90b9 7.86 MiB 9.54 MiB 1.69 MiB
dbd526b 7.86 MiB 9.44 MiB 1.58 MiB
81f83eb 7.86 MiB 9.44 MiB 1.58 MiB
793f4dc 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
4481076 7.86 MiB 9.44 MiB 1.58 MiB
cc4e375 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
ec78888 7.86 MiB 9.44 MiB 1.58 MiB

Previous results on branch: fix/ci-updates

Startup times

Revision Plain With Sentry Diff
c6c92e4 1252.10 ms 1265.33 ms 13.22 ms

App size

Revision Plain With Sentry Diff
c6c92e4 20.70 MiB 22.46 MiB 1.75 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 493.08 ms 595.56 ms 102.48 ms
Size 6.54 MiB 7.70 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2d675d 457.92 ms 529.17 ms 71.25 ms
6f47800 451.04 ms 509.64 ms 58.60 ms
79f6b41 469.66 ms 525.90 ms 56.24 ms
0fb3800 465.64 ms 536.77 ms 71.13 ms
cc4e375 426.15 ms 482.34 ms 56.19 ms
f761369 462.73 ms 563.80 ms 101.06 ms
de377fd 572.35 ms 589.21 ms 16.87 ms
6b69699 456.06 ms 557.44 ms 101.38 ms
0fb45d0 482.79 ms 554.02 ms 71.23 ms
827bf09 475.40 ms 547.14 ms 71.74 ms

App size

Revision Plain With Sentry Diff
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
6f47800 6.54 MiB 7.69 MiB 1.15 MiB
79f6b41 6.54 MiB 7.69 MiB 1.15 MiB
0fb3800 6.54 MiB 7.69 MiB 1.15 MiB
cc4e375 6.54 MiB 7.69 MiB 1.15 MiB
f761369 6.54 MiB 7.70 MiB 1.16 MiB
de377fd 6.54 MiB 7.71 MiB 1.17 MiB
6b69699 6.54 MiB 7.70 MiB 1.17 MiB
0fb45d0 6.54 MiB 7.70 MiB 1.17 MiB
827bf09 6.54 MiB 7.53 MiB 1015.27 KiB

Previous results on branch: fix/ci-updates

Startup times

Revision Plain With Sentry Diff
c6c92e4 511.28 ms 517.76 ms 6.47 ms

App size

Revision Plain With Sentry Diff
c6c92e4 6.54 MiB 7.70 MiB 1.17 MiB

@denrase denrase marked this pull request as ready for review August 19, 2025 08:34
@denrase denrase requested a review from buenaflor August 19, 2025 09:06
@denrase
Copy link
Collaborator Author

denrase commented Aug 19, 2025

Also we need to set macos-15 instead of latest, as latest could also point to macos-14, at least that's how i'm interpretating this info: https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates/#macos-latest-migration-begins-august-4-2025

So from Sep. 1 it should always be macos-15

cursor[bot]

This comment was marked as outdated.

@denrase denrase merged commit 05da225 into main Aug 19, 2025
66 checks passed
@denrase denrase deleted the fix/ci-updates branch August 19, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants