Skip to content

feat(logs): add origin to logs created by LoggingIntegration #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2025
Merged

feat(logs): add origin to logs created by LoggingIntegration #3153

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f0e4d3
Update
buenaflor Aug 7, 2025
f949d18
Update
buenaflor Aug 7, 2025
9f2b89f
Update
buenaflor Aug 7, 2025
14a6d48
Update
buenaflor Aug 7, 2025
d6d541b
Update
buenaflor Aug 7, 2025
9efdff4
Update
buenaflor Aug 7, 2025
9ba3ffd
Update
buenaflor Aug 7, 2025
fc1bc39
Update
buenaflor Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/logging/lib/src/logging_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';

import 'package:meta/meta.dart';
import 'package:logging/logging.dart';
import 'package:sentry/sentry.dart';

Expand Down Expand Up @@ -49,6 +50,9 @@ class LoggingIntegration implements Integration<SentryOptions> {
late Hub _hub;
late SentryOptions _options;

@internal
static const origin = 'auto.log.logging';
Copy link
Contributor Author

@buenaflor buenaflor Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g Java will add auto.log.logback for their logback integration with logs

also open to replacing logging with something else but since it's the name of the package it's fine I think


@override
void call(Hub hub, SentryOptions options) {
_hub = hub;
Expand Down Expand Up @@ -98,6 +102,7 @@ class LoggingIntegration implements Integration<SentryOptions> {
'loggerName': SentryLogAttribute.string(record.loggerName),
'sequenceNumber': SentryLogAttribute.int(record.sequenceNumber),
'time': SentryLogAttribute.int(record.time.millisecondsSinceEpoch),
'sentry.origin': SentryLogAttribute.string(origin),
};

// Map log levels based on value ranges
Expand Down
1 change: 1 addition & 0 deletions packages/logging/test/logging_integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ void main() {
expect(basicAttributes['loggerName']?.value, 'TestLogger');
expect(basicAttributes['sequenceNumber']?.value, isA<int>());
expect(basicAttributes['time']?.value, isA<int>());
expect(basicAttributes['sentry.origin']?.value, LoggingIntegration.origin);
expect(basicAttributes.containsKey('error'), false);
expect(basicAttributes.containsKey('stackTrace'), false);

Expand Down
Loading