- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 276
 
          feat(logs): add origin to logs created by LoggingIntegration
          #3153
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
  | 
    
| late SentryOptions _options; | ||
| 
               | 
          ||
| @internal | ||
| static const origin = 'auto.log.logging'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g Java will add auto.log.logback for their logback integration with logs
also open to replacing logging with something else but since it's the name of the package it's fine I think
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #3153      +/-   ##
==========================================
+ Coverage   88.63%   97.01%   +8.38%     
==========================================
  Files         278        2     -276     
  Lines        9492       67    -9425     
==========================================
- Hits         8413       65    -8348     
+ Misses       1079        2    -1077     ☔ View full report in Codecov by Sentry.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good!
📜 Description
Added needed origin: https://develop.sentry.dev/sdk/telemetry/logs/#sdk-integration-attributes
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps