Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 7, 2025

📜 Description

Added needed origin: https://develop.sentry.dev/sdk/telemetry/logs/#sdk-integration-attributes

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fc1bc39

late SentryOptions _options;

@internal
static const origin = 'auto.log.logging';
Copy link
Contributor Author

@buenaflor buenaflor Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g Java will add auto.log.logback for their logback integration with logs

also open to replacing logging with something else but since it's the name of the package it's fine I think

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (267cbb7) to head (fc1bc39).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3153      +/-   ##
==========================================
+ Coverage   88.63%   97.01%   +8.38%     
==========================================
  Files         278        2     -276     
  Lines        9492       67    -9425     
==========================================
- Hits         8413       65    -8348     
+ Misses       1079        2    -1077     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@buenaflor buenaflor merged commit 8d8099c into main Aug 7, 2025
21 checks passed
@buenaflor buenaflor deleted the logs/add-sentry-origin branch August 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants