fix: Crashed thread is included in the thread list

[itaybre]

Ensure crash thread is included in the thread list and fix memory is not allocated

Closes #6378

[linear]

COCOA-526 Probably a mistake in function getThreadList

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@fbcffd6). Learn more about missing BASE report.
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main     #6377   +/-   ##
========================================
  Coverage        ?   86.764%           
========================================
  Files           ?       439           
  Lines           ?     37255           
  Branches        ?     17370           
========================================
  Hits            ?     32324           
  Misses          ?      4885           
  Partials        ?        46           

Files with missing lines	Coverage Δ
...yCrash/Recording/Tools/SentryCrashMachineContext.c	83.529% <100.000%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbcffd6...a4947b3. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.69 ms	1250.35 ms	22.66 ms
Size	23.75 KiB	987.85 KiB	964.11 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
2481950	1221.04 ms	1248.98 ms	27.94 ms
3ffd0e5	1228.04 ms	1253.04 ms	25.00 ms
5cbd333	1219.93 ms	1241.76 ms	21.83 ms
5d238d3	1228.94 ms	1253.04 ms	24.10 ms
884b224	1221.11 ms	1255.88 ms	34.77 ms
7f2f69c	1237.61 ms	1266.96 ms	29.35 ms
1fecbb8	1242.78 ms	1265.40 ms	22.62 ms
a9fac2e	1212.45 ms	1219.67 ms	7.22 ms
ea5a59b	1222.87 ms	1253.47 ms	30.60 ms
934eee4	1222.51 ms	1251.04 ms	28.53 ms

App size

Revision	Plain	With Sentry	Diff
2481950	23.74 KiB	872.74 KiB	849.00 KiB
3ffd0e5	23.75 KiB	947.55 KiB	923.80 KiB
5cbd333	23.74 KiB	969.77 KiB	946.02 KiB
5d238d3	23.75 KiB	913.62 KiB	889.88 KiB
884b224	23.75 KiB	879.55 KiB	855.80 KiB
7f2f69c	23.75 KiB	913.38 KiB	889.63 KiB
1fecbb8	23.75 KiB	969.28 KiB	945.53 KiB
a9fac2e	23.75 KiB	879.53 KiB	855.78 KiB
ea5a59b	23.75 KiB	874.46 KiB	850.71 KiB
934eee4	23.75 KiB	988.03 KiB	964.28 KiB

Previous results on branch: itay/cocoa-526-probably-a-mistake-in-function-getthreadlist

Startup times

Revision	Plain	With Sentry	Diff
09ba3cb	1226.81 ms	1260.85 ms	34.04 ms
98b2c94	1215.78 ms	1254.37 ms	38.59 ms

App size

Revision	Plain	With Sentry	Diff
09ba3cb	23.75 KiB	991.82 KiB	968.07 KiB
98b2c94	23.75 KiB	987.97 KiB	964.23 KiB

[itaybre]

Unit tests will be fixed once #6375 is merged

[philipphofmann]

LGTM, with a couple of comments. Thanks @itaybre