Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 28, 2025

Derived from #6292 for stacked merging

#skip-changelog

cursor[bot]

This comment was marked as outdated.

Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests

Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
@philprime philprime self-assigned this Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.510%. Comparing base (11853e6) to head (00404d6).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6569       +/-   ##
=============================================
+ Coverage   85.471%   85.510%   +0.039%     
=============================================
  Files          451       451               
  Lines        27566     27565        -1     
  Branches     12071     12070        -1     
=============================================
+ Hits         23561     23571       +10     
+ Misses        3958      3949        -9     
+ Partials        47        45        -2     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11853e6...00404d6. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app graphite-app bot changed the base branch from philprime/fix-masking_split_2 to graphite-base/6569 October 29, 2025 09:56
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@philprime philprime changed the base branch from graphite-base/6569 to philprime/fix-masking_split_2 October 29, 2025 10:52
Base automatically changed from philprime/fix-masking_split_2 to main October 29, 2025 12:37
@graphite-app
Copy link

graphite-app bot commented Oct 29, 2025

Merge activity

  • Oct 29, 12:38 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Oct 29, 12:38 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.21 ms 1240.73 ms 36.53 ms
Size 23.75 KiB 1.01 MiB 1016.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
827b50c 1233.27 ms 1267.28 ms 34.01 ms
8745cc0 1228.13 ms 1250.48 ms 22.35 ms
ebc72be 1221.24 ms 1249.66 ms 28.42 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
331dad6 1210.40 ms 1242.06 ms 31.67 ms
2bddb03 1214.11 ms 1246.78 ms 32.67 ms
916edbe 1243.86 ms 1256.11 ms 12.25 ms
3b4b557 1234.59 ms 1254.02 ms 19.43 ms
b074ba9 1236.52 ms 1248.75 ms 12.23 ms
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms

App size

Revision Plain With Sentry Diff
827b50c 23.75 KiB 1.00 MiB 1005.07 KiB
8745cc0 23.74 KiB 971.81 KiB 948.07 KiB
ebc72be 23.75 KiB 908.22 KiB 884.47 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
331dad6 23.75 KiB 928.12 KiB 904.37 KiB
2bddb03 23.75 KiB 891.01 KiB 867.26 KiB
916edbe 23.75 KiB 908.41 KiB 884.66 KiB
3b4b557 23.75 KiB 908.39 KiB 884.64 KiB
b074ba9 23.74 KiB 976.79 KiB 953.05 KiB
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB

@philprime philprime enabled auto-merge (squash) October 29, 2025 13:37
@philprime philprime disabled auto-merge October 29, 2025 13:42
@philprime philprime enabled auto-merge (squash) October 29, 2025 14:16
@philprime
Copy link
Member Author

After feedback from @noahsmartin I need to remove unnecessary snapshots before merging

@philprime philprime marked this pull request as draft October 29, 2025 14:57
auto-merge was automatically disabled October 29, 2025 14:57

Pull request was converted to draft

@philprime philprime marked this pull request as ready for review November 3, 2025 10:57
@philprime philprime enabled auto-merge (squash) November 3, 2025 10:58
@philprime
Copy link
Member Author

I removed the snapshot testing so this can get merged without bloating the repo more.

@philprime philprime merged commit 32f2329 into main Nov 3, 2025
179 of 180 checks passed
@philprime philprime deleted the philprime/fix-masking_split_3 branch November 3, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants