Discard long-lasting auto-generated transactions #1903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prewarming can execute code up to viewDidLoad of a UIViewController, and keep the app in the background. This can lead to auto-generated transactions lasting for minutes or event hours. Therefore, we drop transactions lasting longer than 5 minutes.
|
|
||
| - (BOOL)isAutoGeneratedTransaction | ||
| { | ||
| return self.waitForChildren || [self hasIdleTimeout]; |
Member
There was a problem hiding this comment.
Isn't waitForChildren a public api folks can use?
brustolin
reviewed
Jun 20, 2022
brustolin
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Prewarming can execute code up to viewDidLoad of a UIViewController,
and keep the app in the background. This can lead to auto-generated
transactions lasting for minutes or event hours. Therefore, we drop
transactions lasting longer than 5 minutes.
💡 Motivation and Context
Another mitigation for #1896 and #1897
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps