Stop reporting pre warmed app starts #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since iOS 15, the system might decide to pre-warm your app before the user tries to open it. In such cases, we can't reliably measure the app start, and we drop it. Otherwise, we would get app start times ranging from one minute to even days. Fixes GH-1849
4 tasks
bruno-garcia
approved these changes
Jun 17, 2022
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Since iOS 15, the system might decide to pre-warm your app
before the user tries to open it. In such cases, we can't reliably
measure the app start, and we drop it. Otherwise, we would get
app start times ranging from one minute to even days.
Docs PR getsentry/sentry-docs#5169
💡 Motivation and Context
Fixes GH-1849
💚 How did you test it?
Unit test
📝 Checklist
🔮 Next steps