Add --no-recreate to dc up in wrap-up.sh only for docker-compose 2.2.4 and more #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
Jul 27, 2022
|
This should be merged after #1591, so the change would be tested. |
aminvakil
force-pushed
the
docker_no_recreate
branch
2 times, most recently
from
34217e3
to
df7e208
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
aminvakil
force-pushed
the
docker_no_recreate
branch
from
df7e208
to
1a60a25
Compare
|
Do we still need this or do you think cons of this change which may appear, are more than the pros it has? |
Temporary fix for getsentry#1294
Co-authored-by: Burak Yigit Kaya <[email protected]>
aminvakil
force-pushed
the
docker_no_recreate
branch
from
1a60a25
to
ad29c91
Compare
|
/gcbrun |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1294
Original PR: #1393
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.