-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker-compose 2.7.0 instead of 2.2.3 in CI #1591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
Closing/reopening because the integration tests seemed stalled. |
I think the stalled test is because it has been changed, and is a github bug. We don't need to run our test on 2.2.3 . |
https://github.com/docker/compose/releases/tag/v2.8.0 has been released, do we want to bump to 2.8.0 instead of 2.7.0? |
I think that is fine! The goal is to use a newer compose, right? |
https://github.com/docker/compose/releases/tag/v2.9.0 has just been released :) |
2825601
to
0684b49
Compare
Maybe we should schedule a daily cron job to update the version :P |
Alright hopefully they don't release another before CI finishes, but once CI is finished I will merge this :) Should we remove the integration test that we seem not use anymore? |
Seems like we're facing new problems 😢 |
I think it will be removed once this is merged, we will see on #1600 then. |
Yes, we're facing new problems 😭
Trying docker-compose 2.8.0 now. |
on docker-compose 2.8.0 too. I've seen something like this on our instance too one time with docker-compose 2.8.0 . From https://github.com/docker/compose/releases/tag/v2.8.0:
But still it seems like both 2.8.0 and 2.9.0 got problems. |
This reverts commit 13a55b9e42d934f29dfe8a52b822a6ff7aa86d92.
5ddd67b
to
ff14f40
Compare
Thanks for changing this! |
Then I'm going to implement #1294 (comment), but first this needs to be merged.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.