-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support docker compose CLI #1116
feat: Support docker compose CLI #1116
Conversation
Check if docker compose v2, CLI, is available and get semantic version from it, or fallback to get semantic version out of docker-compose v1 when checking minimum requirements during install.sh script Fixes #962
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EricsonMacedo thanks a lot for the patch!
I think we need the following to get this patch landed:
- Fix the version check logic so we don't fail on
2.0.0+
- Make sure we use
docker compose
instead ofdocker-compose
by replacing$dc
accordingly - Add a test case into the test matrix for Docker Compose 2.0
Fix getting semantic version of docker compose version 2.0.0 by properly cleaning up possible `v` prefix in version output Assign docker compose CLI if available to $dc alias or fallback to docker-compose Add integration test to check support of docker compose v2 Update install wrap-up message to output the docker compose command based on $dc alias
Please note that: I met some trouble in I have tested in several weeks ago with my own patch, with |
@PMExtra does this patch address some of the issues you had? Btw they released v2.0.1 recently. |
v2.0.1 can be used like before ( So do you think this PR should be reverted (most parts) and using two different approaches for versions < 2 and >=2 would bring confusion for maintaining this repository or not? |
@aminvakil Setting docker-compose binary isn't mandatory, it's an additional compatibility bin/symlink for transition period https://github.com/docker/compose-switch/. In v2 the command to output version isn't |
Check if docker compose v2, CLI, is available and get semantic version
from it, or fallback to get semantic version out of docker-compose v1
when checking minimum requirements during install.sh script
Fixes #962