Skip to content

feat: rename name & target url labels #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amhsirak merged 7 commits into from
Jan 22, 2026
Merged

feat: rename name & target url labels #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98aed63
chore: rename to name
amhsirak Jan 19, 2026
c3a7c11
chore: rename to name
amhsirak Jan 19, 2026
fd60534
feat: remove robot from placeholder & label
amhsirak Jan 19, 2026
b28738b
feat: remove robot from label
amhsirak Jan 19, 2026
0043b4f
feat: remove robot from label
amhsirak Jan 19, 2026
18aa2bb
chore: rename to target url
amhsirak Jan 19, 2026
091c430
feat: rename label to target url
amhsirak Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
},
"save_recording": {
"title": "Save Robot",
"robot_name": "Robot Name",
"robot_name": "Name",
Copy link

@coderabbitai coderabbitai bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# First, list all locale files
echo "=== Locale files available ==="
ls -la public/locales/

echo ""
echo "=== Checking en.json at the specified lines ==="
sed -n '269p;443p;459p;473p' public/locales/en.json

echo ""
echo "=== Checking if other locales exist and their content for the keys ==="
for locale_file in public/locales/*.json; do
  if [ "$locale_file" != "public/locales/en.json" ]; then
    echo ""
    echo "--- File: $locale_file ---"
    # Extract the lines around the keys we're looking for
    echo "Checking for save_recording.robot_name:"
    rg -n "robot_name" "$locale_file" | grep -A1 -B1 "save_recording\|robot_name"
    echo "Checking for robot_duplication.fields.target_url:"
    rg -n "target_url" "$locale_file" | grep -A1 -B1 "robot_duplication\|target_url"
  fi
done

Repository: getmaxun/maxun

Length of output: 2057

Other locale files have not been updated with simplified labels. Consistency needs to be addressed.

The changes in en.json (lines 269, 443, 459, 473) have been simplified to generic labels ("Name", "Target URL"), but the corresponding translations in de.json, es.json, ja.json, tr.json, and zh.json still use longer, descriptive translations. To maintain consistency with the PR objective of simplifying UI labels, these other locale files should also be updated to use shorter, equivalent translations:

  • save_recording.robot_name: Update all locales from descriptive names to simpler equivalents
  • robot_duplication.fields.target_url: Update all locales to simpler forms (e.g., "Ziel-URL" instead of "Roboter Ziel-URL")
  • robot_settings.target_url: Same simplification across all locales
  • robot_edit.change_name: Ensure consistency across all locales
🤖 Prompt for AI Agents 
In `@public/locales/en.json` at line 269, Update the other locale files (de.json,
es.json, ja.json, tr.json, zh.json) to match the simplified English labels by
replacing the long descriptive translations with the shorter equivalents for the
keys save_recording.robot_name, robot_duplication.fields.target_url,
robot_settings.target_url, and robot_edit.change_name; ensure each locale uses a
concise, context-appropriate translation (e.g., "Ziel-URL" for target URL) and
keep the JSON structure and key names identical so the UI shows consistent,
simplified labels across all languages.

"buttons": {
"save": "Save",
"confirm": "Confirm"
Expand Down Expand Up @@ -440,7 +440,7 @@
"warning": "⚠️ Ensure the new page has the same structure as the original page."
},
"fields": {
"target_url": "Robot Target URL"
"target_url": "Target URL"
},
"buttons": {
"duplicate": "Duplicate Robot",
Expand All @@ -456,7 +456,7 @@
},
"robot_settings": {
"title": "Robot Settings",
"target_url": "Robot Target URL",
"target_url": "Target URL",
"robot_id": "Robot ID",
"robot_limit": "Robot Limit",
"created_by_user": "Created By User",
Expand All @@ -470,7 +470,7 @@
},
"robot_edit": {
"title": "Edit Robot",
"change_name": "Robot Name",
"change_name": "Name",
"robot_limit": "Robot Limit",
"save": "Save Changes",
"cancel": "Cancel",
Expand Down
10 changes: 5 additions & 5 deletions src/components/robot/pages/RobotCreate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,12 @@ const RobotCreate: React.FC = () => {
<Box sx={{ width: '100%', maxWidth: 700 }}>
<Box sx={{ mb: 3 }}>
<TextField
placeholder="Robot Name"
placeholder="Name"
variant="outlined"
fullWidth
value={extractRobotName}
onChange={(e) => setExtractRobotName(e.target.value)}
label="Robot Name"
label="Name"
/>
</Box>

Expand Down Expand Up @@ -682,7 +682,7 @@ const RobotCreate: React.FC = () => {
value={scrapeRobotName}
onChange={(e) => setScrapeRobotName(e.target.value)}
sx={{ mb: 2 }}
label="Robot Name"
label="Name"
/>
<TextField
placeholder="Example: https://www.ycombinator.com/companies/"
Expand Down Expand Up @@ -843,7 +843,7 @@ const RobotCreate: React.FC = () => {

<Box sx={{ width: '100%', maxWidth: 700, mb: 2 }}>
<TextField
label="Robot Name"
label="Name"
placeholder="Example: YC Companies Crawler"
fullWidth
value={crawlRobotName}
Expand Down Expand Up @@ -1002,7 +1002,7 @@ const RobotCreate: React.FC = () => {

<Box sx={{ width: '100%', maxWidth: 700, mb: 2 }}>
<TextField
label="Robot Name"
label="Name"
placeholder="Example: AI News Monitor"
fullWidth
value={searchRobotName}
Expand Down
2 changes: 1 addition & 1 deletion src/components/robot/pages/RobotEditPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ export const RobotEditPage = ({ handleStart }: RobotSettingsProps) => {
<>
<TextField
label={t("robot_edit.change_name")}
key="Robot Name"
key="Name"
type="text"
value={robot.recording_meta.name}
onChange={(e) => handleRobotNameChange(e.target.value)}
Expand Down
2 changes: 1 addition & 1 deletion src/components/robot/pages/RobotSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const RobotSettingsPage = ({ handleStart }: RobotSettingsProps) => {
{robot.recording_meta.type !== 'search' && (
<TextField
label={t("robot_settings.target_url")}
key="Robot Target URL"
key="Target URL"
value={targetUrl}
InputProps={{
readOnly: true,
Expand Down