-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: rename name & target url labels #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR simplifies UI labels and localization strings across robot-related components by shortening them from more verbose forms (e.g., "Robot Name" to "Name", "Robot Target URL" to "Target URL") in both localization files and component code. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@public/locales/en.json`:
- Line 269: Update the other locale files (de.json, es.json, ja.json, tr.json,
zh.json) to match the simplified English labels by replacing the long
descriptive translations with the shorter equivalents for the keys
save_recording.robot_name, robot_duplication.fields.target_url,
robot_settings.target_url, and robot_edit.change_name; ensure each locale uses a
concise, context-appropriate translation (e.g., "Ziel-URL" for target URL) and
keep the JSON structure and key names identical so the UI shows consistent,
simplified labels across all languages.
| "save_recording": { | ||
| "title": "Save Robot", | ||
| "robot_name": "Robot Name", | ||
| "robot_name": "Name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, list all locale files
echo "=== Locale files available ==="
ls -la public/locales/
echo ""
echo "=== Checking en.json at the specified lines ==="
sed -n '269p;443p;459p;473p' public/locales/en.json
echo ""
echo "=== Checking if other locales exist and their content for the keys ==="
for locale_file in public/locales/*.json; do
if [ "$locale_file" != "public/locales/en.json" ]; then
echo ""
echo "--- File: $locale_file ---"
# Extract the lines around the keys we're looking for
echo "Checking for save_recording.robot_name:"
rg -n "robot_name" "$locale_file" | grep -A1 -B1 "save_recording\|robot_name"
echo "Checking for robot_duplication.fields.target_url:"
rg -n "target_url" "$locale_file" | grep -A1 -B1 "robot_duplication\|target_url"
fi
doneRepository: getmaxun/maxun
Length of output: 2057
Other locale files have not been updated with simplified labels. Consistency needs to be addressed.
The changes in en.json (lines 269, 443, 459, 473) have been simplified to generic labels ("Name", "Target URL"), but the corresponding translations in de.json, es.json, ja.json, tr.json, and zh.json still use longer, descriptive translations. To maintain consistency with the PR objective of simplifying UI labels, these other locale files should also be updated to use shorter, equivalent translations:
save_recording.robot_name: Update all locales from descriptive names to simpler equivalentsrobot_duplication.fields.target_url: Update all locales to simpler forms (e.g., "Ziel-URL" instead of "Roboter Ziel-URL")robot_settings.target_url: Same simplification across all localesrobot_edit.change_name: Ensure consistency across all locales
🤖 Prompt for AI Agents
In `@public/locales/en.json` at line 269, Update the other locale files (de.json,
es.json, ja.json, tr.json, zh.json) to match the simplified English labels by
replacing the long descriptive translations with the shorter equivalents for the
keys save_recording.robot_name, robot_duplication.fields.target_url,
robot_settings.target_url, and robot_edit.change_name; ensure each locale uses a
concise, context-appropriate translation (e.g., "Ziel-URL" for target URL) and
keep the JSON structure and key names identical so the UI shows consistent,
simplified labels across all languages.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.