Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edit note feature #29

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

tresorama
Copy link
Contributor

@tresorama tresorama commented Jun 6, 2023

This PR would close #1


Added "Edit" note feature.

Refactored a bit of the "state" logic of Notes.jsx to handle the new feature.
Added Pencil icon.

Kapture.2023-06-06.at.02.46.34.mp4

@tresorama tresorama requested a review from a team as a code owner June 6, 2023 00:53
@tresorama
Copy link
Contributor Author

Let me know if something is not ok.

PS: forgive the "text" of the first note in the video, I'm tired and didn't know what I was writing either 😎

@tresorama tresorama mentioned this pull request Jun 6, 2023
@tresorama
Copy link
Contributor Author

Commenting to bring attention to this...

@carterlando
Copy link

+1
Please release this

Copy link
Contributor

@adamperrry adamperrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, you did an awesome job matching the icon style too 😄 I'm going to approve and merge it in, and I'll start the process for cutting a release, testing it internally, and publishing.

Thanks for taking the time to make the add-on better!

@adamperrry adamperrry merged commit 1739d17 into getflywheel:master Aug 24, 2023
@tresorama
Copy link
Contributor Author

Great! I enjoyed adding this 😎

Let me know if you need to...

@nickcernis nickcernis mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing
3 participants