New edit note feature #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bgturner
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Thanks for taking a shot at this feature @mircobabini !
I think most of the functionality of editing and saving notes is present, but a few pieces of feedback:
-
EDITbutton not vertically aligned correctly. It looks like the button is just a little bit below the baseline and other icons
-
The styling of the
textareabox doesn't match the edit area of theaddNotetext area. This is probably related to the
| // switch edit mode | ||
| notes[noteIndex].editing = true; | ||
|
|
||
| // todo set autofocus on textarea (like textareaRef) |
There was a problem hiding this comment.
Still need to implement this. Doing this will likely make the styling of the edit box match the "addNote" text box.
|
Editing notes was implemented in #29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many asked for an "edit note" feature. Here we go.