Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds the ChangesPR check waiting
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MCP caller
participant flare_git_impl
participant GitHub check-runs API
participant checks_wait_summary
MCP caller->>flare_git_impl: Send pr_wait request
flare_git_impl->>GitHub check-runs API: Poll PR head check-runs
GitHub check-runs API-->>flare_git_impl: Return CheckRun set
flare_git_impl->>checks_wait_summary: Build elapsed check summary
checks_wait_summary-->>flare_git_impl: Return JSON summary
flare_git_impl-->>MCP caller: Return pr_wait result
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/mcp_server/flare_git.rs`:
- Around line 105-109: Update the polling loop around actions::list_check_runs
so each sleep is capped by the remaining wait_secs budget. Compute the elapsed
time before sleeping, derive the remaining duration, and sleep for the smaller
of poll_interval_secs and that remainder while preserving the existing timeout
and polling behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 812fcd5d-ccf4-4e79-b9f4-796b50f9d386
📒 Files selected for processing (6)
CHANGELOG.mdCONTRIBUTING.mdmise.tomlsrc/github/mcp.rssrc/mcp_server/flare_git.rssrc/mcp_server/types.rs
Summary
mise run verifymirroring CI's fmt/clippy/test gate exactly (CONTRIBUTING.mdpreviously documented a weaker local check that could pass while CI failed).pr_waitaction to theflare_gitMCP tool: a bounded server-side poll loop (default 60s, capped 120s) over PR check runs, replacing manualgh pr checksshell-loop polling.Closes item #118 (both remaining open sub-items: P1 verify gate, P2a wait-for-checks primitive).
Test plan
mise run verifyrun end-to-end in an isolated worktree — clean exit, no failurescargo test --bin agentflare github::mcp::— 8/8 passing incl. 3 newchecks_wait_summarytestsmise run verifyre-run after thepr_waitchange — clean exitSummary by CodeRabbit
pr_waitaction to monitor pull request check runs until completion or a bounded timeout.wait_secsandpoll_interval_secscontrols for polling behavior.