Skip to content

Add knowledge fact import + session snapshot to flare_handoff - #292

Closed
getappz wants to merge 2 commits into
masterfrom
task/218
Closed

Add knowledge fact import + session snapshot to flare_handoff#292
getappz wants to merge 2 commits into
masterfrom
task/218

Conversation

@getappz

@getappz getappz commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Auto-opened on item done for BY-oyXH4yNNaLC2iYP2Uh.

Summary by CodeRabbit

  • New Features

    • Added a pr_status action that summarizes pull request checks, reviews, unresolved review comments, and issue comments.
    • Added optional ISO8601 since filtering for comment history.
    • Added support for retrieving commit check runs, pull request reviews, review comments, and issue comments.
    • Expanded pull request status details, including draft, mergeability, change counts, and branch information.
  • Documentation

    • Updated tool descriptions and action schemas to document pr_status and its filtering options.

getappz added 2 commits July 19, 2026 22:42
…ents

Review-and-fix loops previously needed separate pr_get, run_list, and
raw comment/review API calls per PR. pr_status fetches PR detail, CI
check runs, review verdicts (incl. bot reviewers like CodeRabbit),
line comments, and issue-level comments in one MCP round trip, and
returns a single JSON payload.

Known limitation: the REST API has no isResolved field for review
threads (GraphQL-only), so review_comments includes resolved threads
too -- callers should use judgment on older/superseded ones.
Two problems with the first pass: REST has no thread-resolution field
at all (only GraphQL's reviewThread.isResolved), so old-but-fixed
review comments were indistinguishable from live ones; and every call
re-fetched full comment history with no way to ask for just what's
new.

- pulls::resolved_review_comment_ids: GraphQL lookup of resolved
  review-thread comment ids; pr_status filters review_comments against
  it so only unresolved (still-outstanding) ones survive.
- since (ISO8601) on GitHubRequest, threaded into the REST comment
  fetches (both support ?since= server-side) so repeated pr_status
  calls only pull what's new since the caller's last check.
- Output trimmed to what a fix loop actually needs: passing checks
  become a count instead of a list, reviews dedupe to one entry (the
  latest) per reviewer, and timestamps/html_url/redundant fields are
  dropped entirely.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 98ce4295-0596-4d8f-9129-5d94d8742e4d

📥 Commits

Reviewing files that changed from the base of the PR and between dd13fae and 6989cf6.

📒 Files selected for processing (8)
  • src/github/actions.rs
  • src/github/issues.rs
  • src/github/mcp.rs
  • src/github/models.rs
  • src/github/pulls.rs
  • src/mcp_server.rs
  • src/mcp_server/flare_git.rs
  • src/mcp_server/types.rs

📝 Walkthrough

Walkthrough

Changes

Pull request status

Layer / File(s) Summary
Status response models
src/github/models.rs
Adds pull request metadata and models for checks, reviews, review comments, issue comments, users, and refs, with deserialization tests for optional fields.
GitHub status data retrieval
src/github/actions.rs, src/github/issues.rs, src/github/pulls.rs
Adds paginated REST APIs for checks and comments, review retrieval, resolved review-comment lookup through GraphQL, and request/error handling tests.
Aggregated status JSON
src/github/mcp.rs
Builds trimmed PR status JSON with passing-check counts, latest reviews, unresolved review comments, and issue comments, with focused tests.
MCP action integration
src/mcp_server/flare_git.rs, src/mcp_server/types.rs, src/mcp_server.rs
Adds the pr_status action, optional ISO8601 since filtering, and updated tool schema documentation.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Request as MCP request
  participant Handler as flare_git_impl
  participant GitHub as GitHub APIs
  participant Formatter as pr_status_json
  Request->>Handler: dispatch pr_status
  Handler->>GitHub: fetch PR status data
  GitHub-->>Handler: return checks, reviews, and comments
  Handler->>Formatter: assemble collected data
  Formatter-->>Handler: return trimmed JSON
  Handler-->>Request: return PR status
Loading

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/218
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch task/218

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@getappz

getappz commented Jul 21, 2026

Copy link
Copy Markdown
Owner Author

Redundant auto-open from on BY-oyXH4yNNaLC2iYP2Uh (item #218). That work was already recovered and merged via PR #269, with item #220 tracking its review — both already closed. This PR's branch () contains unrelated leftover content (GitHub API integration files), not the flare_handoff feature the item describes. Closing without merge; not touching the branch itself pending manual review.

@getappz getappz closed this Jul 21, 2026
@getappz

getappz commented Jul 21, 2026

Copy link
Copy Markdown
Owner Author

Correction (previous comment lost text to shell backtick expansion): this PR was auto-opened by the "item done" action on item #218. That work was already recovered and merged via PR #269, with item #220 tracking its review — both already closed. This PR's branch (task/218) contains unrelated leftover content (GitHub API integration files), not the flare_handoff feature item #218 describes. Correctly closed without merge.

@getappz
getappz deleted the task/218 branch July 24, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant