-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DXF extension #543
Add DXF extension #543
Conversation
865abaa
to
7d810d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @woutergd, thanks for the contribution. Looks good.
For the sake of completeness, would you mind adding both gs-dxf-core
and gs-dxf-wps
to the wps-service
? looks to be equally straightforward, just need to add the dependencies and the corresponding locations to the WpsApplicationConfiguration
's @ImportResource
annotation.
Also, have you, or can you, sign a GeoServer individual or corporate contribution license agreement?
Plase check the CONTRIBUTING.md file for instructions, as we hope and invite you to continue contributing to the project :)
5b6a226
to
3921c90
Compare
@groldan thanks for your feedback, I have updated the PR, and squashed already the changes. I haven't signed the contributor license yet, will make sure that that is submitted today. |
@groldan Just to let you know, I just submitted a signed contributor license agreement. |
excellent, thanks a lot. |
This PR adds the DXF output format extension to the WFS service. I already squashed the commits to a single commit. See also issue #531.
Known issues is that two tests are failing, but these were also failing for example on this PR: #541