Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DXF extension #543

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add DXF extension #543

merged 1 commit into from
Oct 8, 2024

Conversation

woutergd
Copy link
Contributor

@woutergd woutergd commented Oct 6, 2024

This PR adds the DXF output format extension to the WFS service. I already squashed the commits to a single commit. See also issue #531.

Known issues is that two tests are failing, but these were also failing for example on this PR: #541

@woutergd woutergd force-pushed the dxf-support branch 2 times, most recently from 865abaa to 7d810d4 Compare October 6, 2024 16:25
@woutergd woutergd changed the title Dxf support Add DXF extension Oct 6, 2024
@woutergd woutergd marked this pull request as ready for review October 6, 2024 16:33
Copy link
Member

@groldan groldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @woutergd, thanks for the contribution. Looks good.
For the sake of completeness, would you mind adding both gs-dxf-core and gs-dxf-wps to the wps-service? looks to be equally straightforward, just need to add the dependencies and the corresponding locations to the WpsApplicationConfiguration's @ImportResource annotation.

Also, have you, or can you, sign a GeoServer individual or corporate contribution license agreement?
Plase check the CONTRIBUTING.md file for instructions, as we hope and invite you to continue contributing to the project :)

src/apps/geoserver/wfs/pom.xml Outdated Show resolved Hide resolved
src/apps/geoserver/webui/pom.xml Outdated Show resolved Hide resolved
@woutergd woutergd force-pushed the dxf-support branch 3 times, most recently from 5b6a226 to 3921c90 Compare October 8, 2024 07:04
@woutergd
Copy link
Contributor Author

woutergd commented Oct 8, 2024

@groldan thanks for your feedback, I have updated the PR, and squashed already the changes. I haven't signed the contributor license yet, will make sure that that is submitted today.

@woutergd
Copy link
Contributor Author

woutergd commented Oct 8, 2024

@groldan Just to let you know, I just submitted a signed contributor license agreement.

@woutergd woutergd requested a review from groldan October 8, 2024 10:59
@groldan
Copy link
Member

groldan commented Oct 8, 2024

@groldan Just to let you know, I just submitted a signed contributor license agreement.

excellent, thanks a lot.

@groldan groldan merged commit 9a57659 into geoserver:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants