Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DXF and Geopackage extension #531

Closed
woutergd opened this issue Sep 30, 2024 · 5 comments
Closed

Support for DXF and Geopackage extension #531

woutergd opened this issue Sep 30, 2024 · 5 comments

Comments

@woutergd
Copy link
Contributor

We are verifying if it is possible to integrate the dxf and geopackage output format extensions within Geoserver Cloud. Is there any specific reason that these are currently excluded, or is just due to different priorities that they haven't been added?

Links to the extensions:

@buehner
Copy link
Member

buehner commented Oct 2, 2024

Hi. I don't think that there are technical/blocking reasons that the dxf extension is not (yet) available. For GeoServer Cloud, we always need special code/config to make extensions available. So I guess someone "just has to do it" (at least in case of "simple" extensions" it shouldn't be that hard).

I always wanted to try to make a new extension available for geoserver cloud, so maybe I will find some time within the next days to give the DXF one a try. I will let you know here

@woutergd
Copy link
Contributor Author

woutergd commented Oct 2, 2024

@buehner thanks for your response, good to hear that there are no practical limitations on this addition.

I was already working on the integration, so see the PR over here: #542 with probably the required modifications. If there is anything that need to be changed, just let me know.

@mehul-bayer
Copy link

Is there any documentation outlining the steps or a procedure to add extensions?

@woutergd
Copy link
Contributor Author

woutergd commented Oct 6, 2024

Apparently something went wrong with my PR. I made a new PR with just the DXF extension (#543), this one seems to work fine. It fails on two tests, but I noted that these are unrelated an other PR's had the same issues.

What I found out is that the Geopackage extension wants to use wmsserver / wms as imports, as the extension can used on both WMS and WFS (see https://github.com/geoserver/geoserver/blob/main/src/extension/geopkg-output/src/main/java/applicationContext.xml).

Are there any architectural guidelines what the best implementation is to solve this? I would assume the best solution is to modify the extension upstream to split it into a version for WFS and WMS, and then import both in the dedicated services?

@groldan
Copy link
Member

groldan commented Oct 9, 2024

Closing as fixed by #543

@groldan groldan closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants