Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark paper reference #6174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gassmoeller
Copy link
Member

@Shangxin-Liu in reference to your comment in #6166 (see my reply there).

@Shangxin-Liu
Copy link
Contributor

Thanks for taking this over! @gassmoeller

Keeping both is a good idea! Dannberg et al., 2024 documents your CBF heat flux method in detail but the benchmark is in 2D geometry. Euen et al., 2023 benchmarked the method in 3D spherical shell. The two papers complement each other well! You are on the co-author list of both anyway:)

Just one small point about this pull request. In doc/make_cite_html.py, the added paper is actually the original submission version in 2022 to the GMD discussion. The more appropriate one should be the final version of the publication in 2023. The other two reference entries in doc are the correct final published version.

@Shangxin-Liu
Copy link
Contributor

Shangxin-Liu commented Dec 11, 2024

Hi Rene and Timo, @gassmoeller @tjhei

It seems that the one in the make_cite_html.py is still the 2022 version, as below:

"euen:etal:2023" : "Euen, G.T., Liu, S., Gassmöller, R., Heister, T. and King, S.D., 2022. A comparison of 3-D spherical shell thermal convection results at low to moderate Rayleigh number using ASPECT (version 2.2.0) and CitcomS (version 3.3.1). Geoscientific Model Development Discussions, 2022, pp.1-34. doi:10.5194/gmd-16-3221-2023. https://gmd.copernicus.org/articles/16/3221/2023/",
The title is 2022 version but the link is 2023 version:-)

The one in the bibtext is the correct 2023 version.

@gassmoeller
Copy link
Member Author

Good point I got deceived by Google Scholar ;-). Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants