Fix eqcoeff version number #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feathern
reviewed
Feb 29, 2024
|
Or, alternatively, we could set c11 to 1 for version 1. Then it won't rescale dsdr, if it's set. I think that might be the better route, actually. |
Addresses Nick's comment about version number.
feathern
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #489 inadvertently broke the equation_coefficients file, and how it is interpreted by post_processing/rayleigh_diagnostics. I should have updated the version number from 1-->2 since I changed the number of constants from 10 to 11.
This pull request updates the version number, and also the rayleigh_diagnostics class to read in the equation_coefficients file. I verified it still works on old version=1 equation_coefficients files.
This pull request additionally addresses issue #491, since in version 2, "nconst" and "nfunc" are explicitly written into equation_coefficients.