You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue concerns the file "reference_tools.py" in the post_processing folder. It hard-codes number of constants and functions in the PDE set to 10 and 14 (the most common) but doesn't allow the possibility that (currently only the constants) these could be different, if the user specifies scalar diffusions.
I think this could be handled going forward by assuming all previously generated equation_coefficients files had nconst=10, nfunc=14 and keep the current logic if version=1. Then change the version to 2 in Fortran, and have the new equation_coefficients files also include the nconst and nfunc integers explicitly, directly after the version number is written, and before the "cset" and "fset" are written. Finally, change the equation_coefficients.py file to have the appropriate reading contingency based on version number 2.
The text was updated successfully, but these errors were encountered:
This issue concerns the file "reference_tools.py" in the post_processing folder. It hard-codes number of constants and functions in the PDE set to 10 and 14 (the most common) but doesn't allow the possibility that (currently only the constants) these could be different, if the user specifies scalar diffusions.
I think this could be handled going forward by assuming all previously generated equation_coefficients files had nconst=10, nfunc=14 and keep the current logic if version=1. Then change the version to 2 in Fortran, and have the new equation_coefficients files also include the nconst and nfunc integers explicitly, directly after the version number is written, and before the "cset" and "fset" are written. Finally, change the equation_coefficients.py file to have the appropriate reading contingency based on version number 2.
The text was updated successfully, but these errors were encountered: