Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cmake/test fixes to sdf6 #761

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes issues on sdf6 branch when built on Ubuntu 20.04, as exposed by testing for gazebo-tooling/release-tools#565 and backports terminology fixes in Changelog

Summary

There is a cmake warning and test failure when building sdf6 on Ubuntu 20.04:

These have already been fixed in later versions of libsdformat:

Also, I back ported the use of libsdformat and SDFormat in the Changelog

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

* Also use python3 in test

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner November 25, 2021 16:32
@github-actions github-actions bot added the Gazebo 9️ Dependency of Gazebo classic version 9 label Nov 25, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The homebrew warning is already present on sdf6:

https://build.osrfoundation.org/job/sdformat-ci-sdformat6-homebrew-amd64/35/

@scpeters scpeters merged commit 0c6e7ad into gazebosim:sdf6 Nov 29, 2021
@scpeters scpeters deleted the fix_cmake_warning_6 branch November 29, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gazebo 9️ Dependency of Gazebo classic version 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants