Don't install deprecated parser_urdf.hh header #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scpeters
force-pushed
the
privatize_deprecated_header
branch
from
04f84ec
to
5fb487b
Compare
|
the code_check script apparently doesn't like the visibility macro still being there: |
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 86.44% 86.67% +0.23%
==========================================
Files 59 59
Lines 9066 9066
==========================================
+ Hits 7837 7858 +21
+ Misses 1229 1208 -21
Continue to review full report at Codecov.
|
azeey
approved these changes
May 12, 2020
scpeters
force-pushed
the
privatize_deprecated_header
branch
from
2f840ca
to
b763472
Compare
good call; I was stuck before, but I think it's working now as of b763472 |
|
there were code check complaints about unused private functions, so I made them public (within the private header) and used them in a unit test in 330e6a5 |
|
@osrf-jenkins run tests please |
|
Looks good! |
* Remove unused includes of parser_urdf.hh in tests * mv include/sdf/parser_urdf.hh src, since the contents of this header were deprecated in 9.2 * parser_urdf.hh: remove deprecation macros and warning suppression * parser_urdf.hh: remove visibility macro * codecheck: helper functions public, use in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
…m#268 Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
privatize_deprecated_header
branch
from
330e6a5
to
9e7e222
Compare
|
I just squashed and will "rebase and merge" once CI clears |
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jun 27, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jun 30, 2020
* Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per #244, #276 * Changelog for #308. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…#308) * Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per gazebosim#244, gazebosim#276 * Changelog for gazebosim#308. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…#308) * Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per gazebosim#244, gazebosim#276 * Changelog for gazebosim#308. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jul 2, 2020
* Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per #244, #276 * Changelog for #308. Signed-off-by: Steve Peters <[email protected]>
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
URDF2SDFclass inparser_urdf.hhwas deprecated in bitbucket pr #658, and I believe the plan was to remove it from the public API inlibsdformat10, so this PR removes it from the list of installed headers and moves it to thesrcfolder.I included two additional changes:
I did not remove theI removed theSDFORMAT_VISIBLEmacro forURDF2SDFas it was starting to take a while to figure out how to fix it, so I just left that part out.SDFORMAT_VISIBLEmacro in b763472.