-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-filesystem): fix broken stream with gzipped files #28913
fix(gatsby-source-filesystem): fix broken stream with gzipped files #28913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love those integration tests! And the check at
responseStream.on(`downloadProgress`, progress => {
if (progress.transferred === progress.total || progress.total === null)
is a lot less brittle. Thank you so much for this fix!
Published in |
Is this fix available in |
@ertrzyiks it should be, can you open an issue and a reproduction? 🙏 |
@wardpeet thanks for the quick answer, I will try to reproduce it in a simple setup |
@ertrzyiks it is related I think with my comment: #28983 (comment) |
Hello @vladar seems like this fix was not merged into the next releases however on the same code and image trying it with version 3.0.0 or 3.14.0 , or even version 4 it shows the error . Thanks |
@wardpeet |
Description
When creating #28547 we didn't think of gzip, brotli compression when doing remote file downloads. SVGs for example have this issue. Costco reported this issue. I did a fix and created some integration tests to see that it actually works.