fix(gatsby-source-filesystem): Retry a download if a file is incomplete #28547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
removed
the
status: triage needed
wardpeet
reviewed
Dec 9, 2020
pieh
reviewed
Dec 9, 2020
pieh
reviewed
Dec 9, 2020
packages/gatsby-source-filesystem/src/create-remote-file-node.js
Outdated
Show resolved
Hide resolved
wardpeet
approved these changes
Dec 10, 2020
This was referenced Mar 15, 2021
Open
Open
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading a file from a remote under pressure, we have seen cases where the download might be incomplete, especially in cases of images. Such files will break
sharpwhen it attempts to process them with an Error because they are corrupt.One (not exhaustive) nice to have check to prevent this is to assert that the bytes written to disk and equal to the
Content-Lengthsent in HTTP headers (when present).This PR adds that check and retries if the check fails.