Improve createPages of blog starter #10781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Jan 2, 2019
starters/blog/gatsby-node.js
Outdated
| ` | ||
| ).then(result => { | ||
| if (result.errors) { | ||
| console.log(result.errors) |
There was a problem hiding this comment.
We probably don't need to log here since the console will (already) output the thrown error, correct?
There was a problem hiding this comment.
Thanks. The log is unnecessary so I remove it.
DSchau
approved these changes
Jan 2, 2019
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
## Description Remove extra promise in `starters/blog/gatsby-node.js`. ## Related Issues The same fixes is made for these pull requests. gatsbyjs#10357 gatsbyjs#10777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove extra promise in
starters/blog/gatsby-node.js.Related Issues
The same fixes is made for these pull requests.
#10357
#10777