docs(gatsby): improve createPages example #10777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Jan 2, 2019
| * } | ||
| * `).then(result => { | ||
| * if (result.errors) { | ||
| * reject(result.errors) |
There was a problem hiding this comment.
Suggested change
| * reject(result.errors) | |
| * return Promise.reject(result.errors) |
There was a problem hiding this comment.
Oh this should be a throw, yikes, didn't read this very closely.
| * // Query for markdown nodes to use in creating pages. | ||
| * // You can query for whatever data you want to create pages for e.g. | ||
| * // products, portfolio items, landing pages, etc. | ||
| * graphql(` |
There was a problem hiding this comment.
Do we want to return here? It doesn't really matter either way, but it doesn't hurt
| * ) | ||
| * }) | ||
| * | ||
| * return |
There was a problem hiding this comment.
We can probably just drop this? The flow ends here anyways, particularly if we return the graphql call above.
DSchau
changed the title
DSchau
pushed a commit
that referenced
this pull request
Jan 2, 2019
gatsbybot
pushed a commit
to gatsbyjs/gatsby-starter-blog
that referenced
this pull request
Jan 2, 2019
## Description Remove extra promise in `starters/blog/gatsby-node.js`. ## Related Issues The same fixes is made for these pull requests. gatsbyjs/gatsby#10357 gatsbyjs/gatsby#10777
|
Hmm now that I think about it, in the past I've avoided throwing because that meant you couldn't get to graphiql to try fixing the error. I wonder if we should automatically catch graphql errors internally and show a nice clean error with a link to open the query as is in graphiql and never return graphql errors. /cc @gatsbyjs/core |
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
<!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> <!-- Write a brief description of the changes introduced by this PR --> <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc. -->
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
## Description Remove extra promise in `starters/blog/gatsby-node.js`. ## Related Issues The same fixes is made for these pull requests. gatsbyjs#10357 gatsbyjs#10777
ish-xyz
pushed a commit
to ish-xyz/ish-ar.io
that referenced
this pull request
Dec 5, 2019
## Description Remove extra promise in `starters/blog/gatsby-node.js`. ## Related Issues The same fixes is made for these pull requests. gatsbyjs/gatsby#10357 gatsbyjs/gatsby#10777
leonhiat
added a commit
to leonhiat/gatsby-starter-blog
that referenced
this pull request
Oct 31, 2023
## Description Remove extra promise in `starters/blog/gatsby-node.js`. ## Related Issues The same fixes is made for these pull requests. gatsbyjs/gatsby#10357 gatsbyjs/gatsby#10777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.