[7/9] no grad acc averaging for sum losses #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
Merged
Merged
Closed
garrett361
changed the title
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
99016c3 to
bfd3b00
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
02cef67 to
a873266
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
bfd3b00 to
342d32a
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
a873266 to
dfb0866
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
342d32a to
0ea1143
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
dfb0866 to
bb745f7
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
0ea1143 to
b866596
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
bb745f7 to
7e3a6cd
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
b866596 to
2d8996b
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
7e3a6cd to
95f1240
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
2d8996b to
053c928
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
95f1240 to
7985fce
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
053c928 to
ab7a54b
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
7985fce to
8d5c39b
Compare
prev-branch: padding-free-squashing-3
prev-branch: padding-free-squashing-4
prev-branch: padding-free-squashing-5
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
ab7a54b to
f5e19fa
Compare
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
8d5c39b to
a4d460b
Compare
prev-branch: padding-free-squashing-6
garrett361
force-pushed
the
padding-free-squashing-7
branch
from
a4d460b to
96c734b
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
f5e19fa to
7a3d3dd
Compare
Owner
Author
|
I'm a little skeptical about this commit. It's needed for strict correctness, but it would change the dynamics of upstream's training. Not sure what is best. |
Collaborator
|
ok lets hold off on this first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper scaling for the backward pass when using gradient aggregation and a "sum" loss.