Skip to content

Conversation

@garrett361
Copy link
Owner

@garrett361 garrett361 commented Jun 27, 2025

Two related change:

  • Remove the run_name arg in FlatArguments, because the user-supplied value is currently totally ignored and instead overwritten with data from the user-supplied exp_name arg.
  • Add a new --add_seed_and_date_to_exp_name flag.

In upstream, the seed and runtime date are added to the wandb name and (unless --do_not_randomize_output_dir True is specified) the save path. This is hardcoded behavior.

This PR allows for skipping this addition by --add_seed_and_date_to_run_name False

This ability is important in (at least) the following two cases:

  • When restarting a job, the run name would change due to the new run's updated time.
  • In multi-node scenarios, different nodes would generically get different run name, due to different start times.
PR Title
1 #15 padding-free
2 #16 clean_checkpoints_at_end
3 #17 final_lr_ratio
4 >18 add_seed_and_date_to_run_name
5 #19 additional_model_arguments
6 #20 sync_each_batch=True grad acc
7 #21 no grad acc averaging for sum losses
8 #22 extra reporting
9 #23 local_main_process_first when building dataset

@garrett361 garrett361 mentioned this pull request Jun 27, 2025
@garrett361 garrett361 changed the title [4/9] WIP: add_seed_and_date_to_run_name [4/9] add_seed_and_date_to_run_name Jun 27, 2025
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from d1a5006 to e231062 Compare June 27, 2025 19:23
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from 9cfd9a6 to f205d24 Compare June 27, 2025 19:23
@garrett361 garrett361 requested a review from fabianlim June 27, 2025 19:41
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from e231062 to a2546c2 Compare June 27, 2025 20:21
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from f205d24 to 780f13a Compare June 27, 2025 20:21
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from a2546c2 to bdc2c43 Compare June 27, 2025 20:48
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from 780f13a to 8bd01d8 Compare June 27, 2025 20:48
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from bdc2c43 to 307e01e Compare June 27, 2025 20:54
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from 8bd01d8 to aa6e4b7 Compare June 27, 2025 20:54
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from 307e01e to 0548cfd Compare June 27, 2025 21:17
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from aa6e4b7 to 380cd14 Compare June 27, 2025 21:17
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from 0548cfd to b6d7b83 Compare June 27, 2025 21:19
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from 380cd14 to f5460c2 Compare June 27, 2025 21:19
@garrett361 garrett361 force-pushed the padding-free-squashing-3 branch from b6d7b83 to 7a0671a Compare June 28, 2025 01:39
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch 2 times, most recently from d9a59b6 to 5b827c0 Compare June 28, 2025 01:48
@garrett361 garrett361 changed the title [4/9] add_seed_and_date_to_run_name [4/9] rm run_name, add_seed_and_date_to_exp_name Jun 28, 2025
@fabianlim fabianlim changed the base branch from padding-free-squashing-3 to main June 30, 2025 18:27
prev-branch: padding-free-squashing-3
@garrett361 garrett361 force-pushed the padding-free-squashing-4 branch from 5b827c0 to 16a9336 Compare June 30, 2025 18:33
Copy link
Collaborator

@fabianlim fabianlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if its a good idea to remove run_name

@garrett361
Copy link
Owner Author

Ok, I can undo it. Removing run_name doesn't actually change any behavior though, because run_name was never actually used. The user supplied value is just ignored :/

@garrett361
Copy link
Owner Author

It's true that removing run_name would require users to remove the arg in their configs, even though it is a no-op arg.

@garrett361
Copy link
Owner Author

So, remove?

@fabianlim
Copy link
Collaborator

oh i didnt know it was a no op.. ok fine lets remove

Copy link
Collaborator

@fabianlim fabianlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianlim fabianlim merged commit 7a2fdf2 into main Jun 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants