Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter defaults for QuotaClient.update_quota() #489

Merged
merged 10 commits into from
Jul 27, 2024
Merged

Update parameter defaults for QuotaClient.update_quota() #489

merged 10 commits into from
Jul 27, 2024

Commits on Jul 25, 2024

  1. add test for updating nondefault quotas

    @bernt-matthias
    bernt-matthias committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d5ba358 View commit details
    Browse the repository at this point in the history

  2. try to fix

    @bernt-matthias
    bernt-matthias committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    57caf70 View commit details
    Browse the repository at this point in the history

  3. quota creation needs user id

    @bernt-matthias
    bernt-matthias committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    57a0a6d View commit details
    Browse the repository at this point in the history

  4. is this the intended usage

    @bernt-matthias
    bernt-matthias committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1998f18 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Nicola Soranzo <[email protected]>
    @bernt-matthias @nsoranzo
    bernt-matthias and nsoranzo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4bf4843 View commit details
    Browse the repository at this point in the history

  6. fix linting

    @bernt-matthias
    bernt-matthias committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3086d3b View commit details
    Browse the repository at this point in the history

  7. Change default value of default parameter of ``QuotaClient.update… 

    …_quota()`` to None
    @nsoranzo
    nsoranzo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    904ad43 View commit details
    Browse the repository at this point in the history

  8. Change default value of operation parameter of ``QuotaClient.upda… 

    …te_quota()`` to "="

which is the same of the Galaxy API since 21.09 and makes the
``test_update_non_default_quota`` pass for Galaxy <21.09 without
having to specify the ``operation`` parameter.
    @nsoranzo
    nsoranzo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2da218a View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Update test docstring 

    Co-authored-by: M Bernt <[email protected]>
    @nsoranzo @bernt-matthias
    nsoranzo and bernt-matthias authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9ee0dc1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @bernt-matthias
    bernt-matthias authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ea36144 View commit details
    Browse the repository at this point in the history