Update parameter defaults for QuotaClient.update_quota()

[bernt-matthias]

No description provided.

[bernt-matthias]

I wanted to replicate the error shown in 8f11841:

bioblend.ConnectionError: Unexpected HTTP status code: 400: {"err_msg":"Quota 'non_default_quota' is not a default.","err_code":400008}

Which happens when updating a non-default quota (created with default="no") with default="no". My intuition was that this should work. The problem occurs because the Galaxy tries to unset the default setting if a value of "no" is given

• https://github.com/galaxyproject/galaxy/blob/e18ba472bf941632431d387479e515e3a4cf34c7/lib/galaxy/webapps/galaxy/services/quotas.py#L89

which fails if it is already a non-default quota:

https://github.com/galaxyproject/galaxy/blob/e18ba472bf941632431d387479e515e3a4cf34c7/lib/galaxy/managers/quotas.py#L197

The error message is a bit weird .. and I'm wondering if this should be fixed on bioblend side by

• using None as default value for default
• adding a bit of documentation

Edit: Still does not work for <21.09 (probably before galaxyproject/galaxy#11315). Wondering if we need to care about this or just disable tests for earlier releases.

[nsoranzo]

Pushed to the main branch a fix for:

bioblend/galaxy/workflows/__init__.py:21: error: Unused "type: ignore" comment 
[unused-ignore]
    InputsBy = Literal["step_index|step_uuid", "step_index", "step_id", "s...
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...

[bernt-matthias]

Thanks @nsoranzo . The remaining linter error seems to depend on the answers to the above question(s).

[nsoranzo]

@bernt-matthias Are you happy with the changes I pushed? They align with what the Galaxy API currently does.

[bernt-matthias]

Thanks a lot. Lets go :)