Skip to content

Conversation

@apopiak
Copy link
Contributor

@apopiak apopiak commented Nov 17, 2022

Adds XCM weight trader. Analogous to galacticcouncil/Basilisk-node#443

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have updated the documentation if necessary.
  • I have added tests to cover my changes, regression test if fixing an issue.
  • This is a breaking change.

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Crate versions that have not been updated:

  • hydradx-runtime: v114.0.0
  • testing-hydradx-runtime: v114.0.0

Crate versions that have been updated:

  • runtime-integration-tests: v0.1.2 -> v0.1.3

Runtime version has not been increased.

Copy link
Member

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. i was not aware that the trader impl is not actually there in the config.

btw, it would be great to add additioan integration tests ( can be part of another PR) as to fix #469 .

MultiLocation::new(
1,
X2(
Junction::Parachain(HYDRA_PARA_ID),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: i think this needs a reformat ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running cargo fmt does nothing. What in particular don't you like?

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 85.77% // Head: 85.77% // No change to project coverage 👍

Coverage data is based on head (86105a6) compared to base (cf64633).
Patch has no changes to coverable lines.

❗ Current head 86105a6 differs from pull request most recent head 8cd4ebc. Consider uploading reports for the commit 8cd4ebc to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           polkadot-v0.9.29     #475   +/-   ##
=================================================
  Coverage             85.77%   85.77%           
=================================================
  Files                     8        8           
  Lines                  1005     1005           
=================================================
  Hits                    862      862           
  Misses                  143      143           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@apopiak apopiak changed the title Preview: add XCM weight trader and update integration tests feat!: add XCM weight trader and update integration tests Nov 22, 2022
@apopiak apopiak marked this pull request as ready for review November 22, 2022 12:41
@apopiak apopiak merged commit 1229759 into polkadot-v0.9.29 Nov 22, 2022
@jak-pan jak-pan deleted the apopiak/weight-trader branch February 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants