-
Notifications
You must be signed in to change notification settings - Fork 101
feat!: add XCM weight trader and update integration tests #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Crate versions that have not been updated:
Crate versions that have been updated:
Runtime version has not been increased. |
enthusiastmartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great. i was not aware that the trader impl is not actually there in the config.
btw, it would be great to add additioan integration tests ( can be part of another PR) as to fix #469 .
| MultiLocation::new( | ||
| 1, | ||
| X2( | ||
| Junction::Parachain(HYDRA_PARA_ID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: i think this needs a reformat ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running cargo fmt does nothing. What in particular don't you like?
Codecov ReportBase: 85.77% // Head: 85.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## polkadot-v0.9.29 #475 +/- ##
=================================================
Coverage 85.77% 85.77%
=================================================
Files 8 8
Lines 1005 1005
=================================================
Hits 862 862
Misses 143 143 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…-node into apopiak/weight-trader
…-node into apopiak/weight-trader
Adds XCM weight trader. Analogous to galacticcouncil/Basilisk-node#443
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Checklist: