Skip to content

Conversation

@enthusiastmartin
Copy link
Member

@enthusiastmartin enthusiastmartin commented Nov 8, 2022

@auto-add-label auto-add-label bot added the chore label Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Crate versions that have been updated:

  • runtime-integration-tests: v0.1.1 -> v0.1.3
  • hydradx: v8.1.1 -> v8.2.0
  • pallet-claims: v3.4.1 -> v3.4.2
  • pallet-genesis-history: v1.3.1 -> v1.3.2
  • pallet-omnipool: v1.1.1 -> v1.1.2
  • primitives: v5.0.5 -> v5.0.6
  • common-runtime: v100.2.0 -> v100.2.1
  • hydradx-runtime: v113.0.0 -> v114.0.0
  • testing-hydradx-runtime: v113.0.0 -> v114.0.0

Runtime version has been increased.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 85.77% // Head: 85.77% // No change to project coverage 👍

Coverage data is based on head (1229759) compared to base (c1f70c6).
Patch has no changes to coverable lines.

❗ Current head 1229759 differs from pull request most recent head 4d30769. Consider uploading reports for the commit 4d30769 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files           8        8           
  Lines        1005     1005           
=======================================
  Hits          862      862           
  Misses        143      143           
Impacted Files Coverage Δ
primitives/src/constants.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrq1911 mrq1911 self-requested a review November 11, 2022 16:44
@apopiak
Copy link
Contributor

apopiak commented Nov 17, 2022

Creating the Weight Trader PR based on this and got the following warning when compiling:

warning: use of deprecated type alias `AllPalletsReversedWithSystemFirst`: Using reverse pallet orders is deprecated. use only `AllPalletWithSystem or AllPalletsWithoutSystem`
   --> runtime/hydradx/src/lib.rs:969:2
    |
969 |     AllPalletsReversedWithSystemFirst,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

How do we want to handle this?

@mrq1911
Copy link
Member

mrq1911 commented Nov 21, 2022

Creating the Weight Trader PR based on this and got the following warning when compiling:

warning: use of deprecated type alias `AllPalletsReversedWithSystemFirst`: Using reverse pallet orders is deprecated. use only `AllPalletWithSystem or AllPalletsWithoutSystem`
   --> runtime/hydradx/src/lib.rs:969:2
    |
969 |     AllPalletsReversedWithSystemFirst,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

How do we want to handle this?

ignore this for now, we have to analyze the impact for this to be changed into a different order #478

# Conflicts:
#	Cargo.lock
#	integration-tests/Cargo.toml
#	runtime/hydradx/Cargo.toml
#	runtime/hydradx/src/lib.rs
#	runtime/testing-hydradx/Cargo.toml
#	runtime/testing-hydradx/src/lib.rs
@mrq1911 mrq1911 changed the title chore: update to v0.9.29 chore: update to substrate v0.9.29 Nov 21, 2022
@mrq1911 mrq1911 changed the title chore: update to substrate v0.9.29 chore: upgrade to substrate v0.9.29 Nov 21, 2022
@mrq1911 mrq1911 merged commit 8dcbba5 into master Nov 23, 2022
@jak-pan jak-pan deleted the polkadot-v0.9.29 branch February 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants