Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(etherscan): additional chain apis #1343

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Jun 3, 2022

Motivation

Solution

Additional chains that have Blockscout explorer

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Test Cases

Deployments with forge create --verify

@rkrasiuk rkrasiuk marked this pull request as draft June 3, 2022 07:02
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should add a comment that their API is etherscan compatible,
do they also have the constructorArguements typo in the verify API?

@rkrasiuk
Copy link
Contributor Author

rkrasiuk commented Jun 3, 2022

@mattsse good point. regarding the typo, it seems that they support both - with & without a typo.

I'll mark this PR as RFR after adding support for more chains

@rkrasiuk rkrasiuk marked this pull request as ready for review June 3, 2022 15:57
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants