-
Notifications
You must be signed in to change notification settings - Fork 796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chain ids lgtm
but explorer appears to be not related to etherscan, so I think we shouldn't add the endpoints here because etherscan API not supported?
Chain::Emerald => { | ||
urls("https://explorer.emerald.oasis.dev/api", "https://explorer.emerald.oasis.dev") | ||
} | ||
Chain::EmeraldTestnet => urls( | ||
"https://testnet.explorer.emerald.oasis.dev/api", | ||
"https://testnet.explorer.emerald.oasis.dev", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this compatible with etherscan API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattsse This project is using the fork for a small POC: https://gunix.codeberg.page/sycamore-metamask-example/
However that's only getting the balance and nothing else.
The explorer is blockscout. According to the docs, it supports ETH RPC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we're using our own fork of the blockscout: https://github.com/oasisprotocol/emerald-blockscout
Let us know, if you require any assistance.
I double-checked and blockscout is claiming their API is compatible for people transitioning from etherscan. If you have concerns, I can write some rust tests to make sure that is true. They do have a lot of tests, but they are all in Elixir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the explorer appears to be compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be compatible
@mattsse that's right |
Thx |
Motivation
Emerald is currently not part of the supported chains within
ethers-rs
.Solution
Added the Emerald Mainnet and Testnet chains.
PR Checklist
Added TestsExisting tests passed.Added DocumentationExtra documentation not required.