Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

add support for Emerald (from Oasis) #1236

Closed
wants to merge 3 commits into from

Conversation

hiram-abif
Copy link

@hiram-abif hiram-abif commented May 8, 2022

Motivation

Emerald is currently not part of the supported chains within ethers-rs.

Solution

Added the Emerald Mainnet and Testnet chains.

PR Checklist

  • Added Tests Existing tests passed.
  • Added Documentation Extra documentation not required.
  • Updated the changelog

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain ids lgtm

but explorer appears to be not related to etherscan, so I think we shouldn't add the endpoints here because etherscan API not supported?

Comment on lines +267 to +273
Chain::Emerald => {
urls("https://explorer.emerald.oasis.dev/api", "https://explorer.emerald.oasis.dev")
}
Chain::EmeraldTestnet => urls(
"https://testnet.explorer.emerald.oasis.dev/api",
"https://testnet.explorer.emerald.oasis.dev",
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this compatible with etherscan API?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse This project is using the fork for a small POC: https://gunix.codeberg.page/sycamore-metamask-example/
However that's only getting the balance and nothing else.

The explorer is blockscout. According to the docs, it supports ETH RPC

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're using our own fork of the blockscout: https://github.com/oasisprotocol/emerald-blockscout

Let us know, if you require any assistance.

@hiram-abif
Copy link
Author

but explorer appears to be not related to etherscan, so I think we shouldn't add the endpoints here because etherscan API not supported?

I double-checked and blockscout is claiming their API is compatible for people transitioning from etherscan. If you have concerns, I can write some rust tests to make sure that is true. They do have a lot of tests, but they are all in Elixir.

Copy link

@0xvv 0xvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the explorer appears to be compatible

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be compatible

@mattsse
Copy link
Collaborator

mattsse commented Jun 6, 2022

@rkrasiuk I believe we can close this since #1343 added emerald support?

vote close @gakonst

@rkrasiuk
Copy link
Contributor

rkrasiuk commented Jun 6, 2022

@mattsse that's right

@gakonst gakonst closed this Jun 6, 2022
@gakonst
Copy link
Owner

gakonst commented Jun 6, 2022

Thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants