Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container-fluid from body in index.html #8

Open
payne-chris-r opened this issue Oct 19, 2016 · 6 comments
Open

Remove container-fluid from body in index.html #8

payne-chris-r opened this issue Oct 19, 2016 · 6 comments
Labels
question

Comments

@payne-chris-r
Copy link
Contributor

<body class="container-fluid"> should be something the user adds IMO. Maybe we leave it there to show you can add classes to the body in index.html? Not sure. It just drove me insane for 15 minutes though.
@payne-chris-r payne-chris-r changed the title Remove container-fluid from body in `index.html Remove container-fluid from body in index.html Oct 19, 2016
@gaand
Copy link

gaand commented Oct 19, 2016

Ember does some bootstrapy stuff when you install bootstrap-sass, so that should probably be investigated?

@raq929
Copy link
Contributor

raq929 commented Dec 14, 2016

I would actually support removing this from browser-template as well. (pending investigation)

@raq929 raq929 mentioned this issue Dec 14, 2016
Open
raq929 pushed a commit that referenced this issue Dec 14, 2016
Remove 'containter-fluid' from index.html
00f941c 
People should be configuring bootstrap on their own.
Close #8
@gaand
Copy link

gaand commented Dec 15, 2016

@raq929 This means I won't merge your pull. Perhaps this is the correct change, but I do not believe this has been investigated or discussed enough to warrant the action you took.

@raq929
Copy link
Contributor

raq929 commented Dec 15, 2016

Sorry, I meant to test it and then remove the commit before making the pull. I'll update and re-push the branch.

@jrhorn424
Copy link
Contributor

I don't care if it goes. I added it originally because developers forget to add it themselves and then their apps bleed all the way to the viewport edge and it drives me nuts.

It just drove me insane for 15 minutes though.

That's not a good reason to remove something, IMO. You should know better. 😛

@payne-chris-r
Copy link
Contributor Author

^ 100%. I was just frustrated and it didn't make sense to me that it would be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrhorn424 @gaand @payne-chris-r @raq929