Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container-fluid from body in index.html #73

Open
raq929 opened this issue Dec 14, 2016 · 3 comments
Open

Remove container-fluid from body in index.html #73

raq929 opened this issue Dec 14, 2016 · 3 comments
Labels

Comments

@raq929
Copy link

raq929 commented Dec 14, 2016

I agree with @payne-chris-r in ga-wdi-boston/ember-template#8

@jrhorn424
Copy link
Contributor

I don't agree.

If it is to be removed, it should be removed because we shouldn't be providing anything in the HTML anyway.

Providing sensible defaults is the whole reason for a template. As long as we're providing bootstrap by default, the body should have container-fixed or container-fluid.

@payne-chris-r
Copy link
Contributor

Yeahhh. I see your point. What if we just put a note/comment in there? Or maybe this comes into play with the template magic talk?

@Jcornmanhomonoff
Copy link

@payne-chris-r I don't have much of an opinion on this one. I see both sides to this argument but I do believe that in a lot of our other repos that include an index.html they have the container-fluid class attached to the body. At the very least I think we should keep it consistent. Developers should already have experience interacting with a page with this class on it so there shouldn't be much confusion on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants