[Hardware Support] AMD - ROCM #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aver_numa/tree/numaFAILED ; Run test torch_memory_saver_yusheng/test/test_examples.py::test_simple[preload] - assert False FAILED torch_memory_saver_yusheng/test/test_examples.py::test_cuda_graph[preload] - assert False FAILED torch_memory_saver_yusheng/test/test_examples.py::test_cpu_backup[preload] - assert False FAILED torch_memory_saver_yusheng/test/test_examples.py::test_cpu_backup[torch] - assert False FAILED torch_memory_saver_yusheng/test/test_examples.py::test_multi_device[preload] - assert False FAILED torch_memory_saver_yusheng/test/test_examples.py::test_multi_device[torch] - assert False
Owner
|
offline sync:
|
fzyzcjy
reviewed
Aug 12, 2025
Owner
fzyzcjy
left a comment
fzyzcjy
left a comment
There was a problem hiding this comment.
I do not check rocm branch and only look at changes to existing code. the nits below are almost only formats instead of real logic, thus may be solved very easily
fzyzcjy
reviewed
Aug 12, 2025
fzyzcjy
reviewed
Aug 12, 2025
Contributor
|
@yushengsu-thu do you want to modify my setup in SGLang to also support sgl-project/sglang#8813 |
Contributor
Author
|
@EduardDurech Could we have a quick online call to discuss this (mail: [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this #14 into tms.