Skip to content

Conversation

@YangWang92
Copy link

@YangWang92 YangWang92 commented May 25, 2025

Due to internal constraints in ROCm/HIP, virtual-memory allocation must be performed chunk-wise for large memory allocation. In addition, avoid using ROCm 6.4.0, an internal bug prevents memory from being released. This commit follows the approach introduced in vllm-project/vllm#12695.

EDIT by tom to make github happy:
Close #9

Copy link
Owner

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Firstly one thought

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering is it possible we unify the CUDA and HIP versions to avoid code duplication

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possbile to reuse CUDA and HIP versions, but current HIP version requires the chunk-wise allocation. Should I merge them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is discussed in DM, wondering whether it is possible to make a layered cake - one low-level layer that provides a unified API and hides diffs from CUDA and HIP, and a high-level layer that consumes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AMD MI-300 GPU] Encounter cu_mem_create issue in multi-node

3 participants