fix apply regression and made LoadPath private #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks, this looks good to me.
@Bluebugs are you happy with this update applied over the previous changes?
Bluebugs
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression added in #34 in
selfupdate.applythe customopts.TargetPathwas ignored when settingnewPathandoldPath,reverted all changes to
selfupdate.applyin commit dfea30c.LoadPathis now private andExecutableNewPathgot removed.Sorry for the trouble!