Public export of getExecutableRealPath and refactoring loading the exe path

[FLuzzi-csw]

Export to the public the call to getExecutableRealPath since it can be usefull,
also added the sibling calls GetExecutableDefaultOldPath and GetExecutableNewPath.

The function LoadPath is sync.Once to limit performance related issues

[Bluebugs]

Just a small change request, looks good otherwise and thanks for the tests.

[FLuzzi-csw]

The ci is failing while downloading github.com/mattn/goveralls
https://github.com/fynelabs/selfupdate/actions/runs/7545086229/job/20540137088

It seems that GO111MODULE=off is the problem, fixed in e12750b

[Bluebugs]

The ci is failing while downloading github.com/mattn/goveralls https://github.com/fynelabs/selfupdate/actions/runs/7545086229/job/20540137088

It seems that GO111MODULE=off is the problem, fixed in e12750b

Yeah, I am just running the test again. If it doesn't pass, the way it could work is by bumping the minimal version of go to 1.19 (and max to 1.21) along with using go install github.com/mattn/goveralls@latest instead of go get github.com/mattn/goveralls

[Bluebugs]

It actually passed. Well, will do a different PR for upgrading the version.

[andydotxyz]

Shouldn't the "LoadPath method be private? It doesn't seem to perform any public function.

[FLuzzi-csw]

I thought of LoadPath as a fail fast route if you need to call multiple times GetExecutableRealPath, GetExecutableDefaultOldPath and GetExecutableNewPath (i've applied this logic in the function selfupdate.apply).

Maybe I could have written the docs to be more clear on it's usage or make LoadPath a must call before GetExecutableRealPath & Co, even though that seems excessive to me.

Let me know if you need any further clarifications or modifications

[andydotxyz]

That doesn't seem to explain why it should be public. It runs the code just once and is always executed before any of the getters return. Why expose it at all?

[FLuzzi-csw]

To give an a different and clear escape hatch if something goes wrong, making all the following calls to the getters "safe",
without forcing you to call it at the start of the program. (that seems a nightmare)

That said, if this is not seen as useful or maybe decremental, I can make LoadPath private.

[andydotxyz]

making all the following calls to the getters "safe", without forcing you to call it at the start of the program.

This is what I am not understanding. What is unsafe about not calling the LoadPath manually? None of the test code calls it.

[FLuzzi-csw]

Got the lightbulb moment, that is just redundant at best and confusing at worst.

Tell me if you want to fix it, otherwise I'll make a PR later in the day.
Thanks for the feedback

[andydotxyz]

If you are happy to fix this with another PR that would be excellent thanks.