Skip to content

Commit

Permalink
Mirgate jar dependencies for testing to rules_jvm_external
Browse files Browse the repository at this point in the history
Remove checked-in jars used for `//src/test/java/...` and fetch them with rules_jvm_external instead.

Working towards: bazelbuild#17036

Closes bazelbuild#17812.

PiperOrigin-RevId: 518608132
Change-Id: I6a0d282febc27c538b5297054facc70a5a0ca35d
  • Loading branch information
meteorcloudy authored and copybara-github committed Mar 22, 2023
1 parent 2a3ab5c commit 6cbe0f1
Show file tree
Hide file tree
Showing 4 changed files with 372 additions and 18 deletions.
16 changes: 14 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,8 @@ maven_install(
"javax.activation:javax.activation-api:1.2.0",
"javax.annotation:javax.annotation-api:1.3.2",
"javax.inject:javax.inject:1",
"net.bytebuddy:byte-buddy-agent:1.9.7",
"net.bytebuddy:byte-buddy:1.9.7",
"net.bytebuddy:byte-buddy-agent:1.11.13",
"net.bytebuddy:byte-buddy:1.11.13",
"org.apache.commons:commons-compress:1.19",
"org.apache.commons:commons-pool2:2.8.0",
"org.apache.tomcat:tomcat-annotations-api:8.0.5",
Expand All @@ -740,7 +740,19 @@ maven_install(
"org.pcollections:pcollections:3.1.4",
"org.threeten:threeten-extra:1.5.0",
"org.tukaani:xz:1.9",
# The following jars are for testing.
# junit is not test only due to //src/java_tools/junitrunner/java/com/google/testing/junit/junit4:runner,
# and hamcrest is a dependency of junit.
"junit:junit:4.13.2",
"org.hamcrest:hamcrest-core:1.3",
maven.artifact("com.google.guava", "guava-testlib", "31.1-jre", testonly = True),
maven.artifact("com.google.jimfs", "jimfs", "1.2", testonly = True),
maven.artifact("com.google.testing.compile", "compile-testing", "0.18", testonly = True),
maven.artifact("com.google.truth", "truth", "1.1.3", testonly = True),
maven.artifact("com.google.truth.extensions", "truth-java8-extension", "1.1.3", testonly = True),
maven.artifact("com.google.truth.extensions", "truth-liteproto-extension", "1.1.3", testonly = True),
maven.artifact("com.google.truth.extensions", "truth-proto-extension", "1.1.3", testonly = True),
maven.artifact("org.mockito", "mockito-core", "3.12.4", testonly = True),
],
excluded_artifacts = [
# org.apache.httpcomponents and org.eclipse.jgit:org.eclipse.jgit
Expand Down
Loading

0 comments on commit 6cbe0f1

Please sign in to comment.