Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirgate jar dependencies for testing to rules_jvm_external #17812

Closed
wants to merge 5 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Mar 17, 2023

Remove checked-in jars used for //src/test/java/... and fetch them with rules_jvm_external instead.

Working towards: #17036

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Mar 17, 2023
@meteorcloudy
Copy link
Member Author

function setup_javatest_common() {
# TODO(bazel-team): we should use remote repositories.
mkdir -p third_party
if [ ! -f third_party/BUILD ]; then
cat <<EOF >third_party/BUILD
package(default_visibility = ["//visibility:public"])
EOF
fi
[ -e third_party/junit.jar ] || ln -s ${junit_jar} third_party/junit.jar
[ -e third_party/hamcrest.jar ] \
|| ln -s ${hamcrest_jar} third_party/hamcrest.jar
}

Tests failing because we also use some jars in shell test setup. :(

@meteorcloudy meteorcloudy marked this pull request as draft March 20, 2023 12:48
@github-actions github-actions bot removed awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Mar 22, 2023
@meteorcloudy meteorcloudy marked this pull request as ready for review March 22, 2023 14:56
@keertk keertk added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Mar 22, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Remove checked-in jars used for `//src/test/java/...` and fetch them with rules_jvm_external instead.

Working towards: bazelbuild#17036

Closes bazelbuild#17812.

PiperOrigin-RevId: 518608132
Change-Id: I6a0d282febc27c538b5297054facc70a5a0ca35d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants