Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect pre-paginated page spreads #927

Merged
merged 7 commits into from
May 15, 2020
Merged

Conversation

mikkelvp
Copy link
Contributor

No description provided.

@fchasen
Copy link
Contributor

fchasen commented Jun 5, 2019

Sorry for the delay reviewing this. Is there an epub I can test it with?

@mikkelvp
Copy link
Contributor Author

Sent you an email.

@fchasen fchasen merged commit 7b8480f into futurepress:master May 15, 2020
@fchasen
Copy link
Contributor

fchasen commented May 15, 2020

Sorry again for the delay on this, thanks for making these fixes - they look great.

@johnfactotum
Copy link
Contributor

This PR works great! But there's a slight issue when going directly to a spine item with the property page-spread-right with rendition.display().

The issue can be reproduced like so:

  1. Open the book "Page Blanche" from EPUB 3 Samples with Epub.js 0.3.87
  2. Run rendition.display(6)
    Actual result: section 6 is displayed on the right side, but the left side is empty
    Expected result: section 6 on the right and section 5 on the left
  3. Now run rendition.prev()
    Actual result: section 5 shows up on the right, and section 4 on the left
    Expected result: section 4 on the right, and section 3 on the left

@mikkelvp
Copy link
Contributor Author

@johnfactotum I'm aware of this. I will look into it sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants